Prospector option to select between form fill and doc creation #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
momuno
commented
Nov 14, 2024
momuno
commented
- document agent - to account for message type of None for welcome message scenario (and future others?)
- prospector chat - removing command, adding workflow branching, support welcome message scenario for doc agent.
- prospector config - add workflow option for form fill or doc creation.
…s and for not providing outline itself. Update logic in doc agent to track turns of step and pass info to gc artifact
… (decoupling to occur later). Address final fixes.
…de upon new conversation or message
bkrabach
reviewed
Nov 14, 2024
|
|
||
| doc_agent = DocumentAgent(attachments_extension) | ||
| await doc_agent.receive_command(config, context, message, metadata) | ||
| pass |
There was a problem hiding this comment.
If we're just going to pass here, consider just deleting this handler until if/when we want it.
bkrabach
reviewed
Nov 14, 2024
|
|
||
| # # Prospector assistant response | ||
| # await respond_to_conversation(context, config, message, metadata) | ||
| if config.guided_workflow == "Form Completion": |
There was a problem hiding this comment.
I'd invert this since form completion is our desired default. Maybe consider using a match w/ the form completion as the default.
There was a problem hiding this comment.
ohh i like the match idea
bkrabach
previously approved these changes
Nov 14, 2024
|
to finish testing tomorrow. so far looking good (with an added fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.